feat(new): improve new contract with a ContractType for categorization #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will refactor |
AlexD10S
approved these changes
Jun 24, 2024
| default_value = ContractType::Examples.as_ref(), | ||
| value_parser = crate::enum_variants!(ContractType) | ||
| )] | ||
| pub(crate) contract_type: Option<ContractType>, |
There was a problem hiding this comment.
I received feedback on a pending PR suggesting that we should make the flags shorter. I like it, do you think makes sense to call it only type? #209 (comment)
There was a problem hiding this comment.
Unfortunately, type is a reserved keyword in Rust. Could maybe do category instead? Could also be c_type, but that's not super clear
There was a problem hiding this comment.
Let's keep it contract_type then, c_type is a bit confusing
AlexD10S
added a commit
that referenced
this pull request
Jun 25, 2024
…201) * feat: ux user guide for contract creation and list contract templates * refactor: add template structure when creating parachain and flipper by default * chore: add git functions to clone repository in pop-contracts * feat: clone repository and extract only template files * feat: rename smart contract * chore: check contract naming * refactor: consistent messaging with parachain generation * docs: add contract templates info in README * fix: fixes ans small refactors * test: add unit tests * test: few more unit test for templates and git * fix: build issue * fix: placeholder for contract and enum_variants error * docs: fix feedback * refactor: pop_common crate * refactor: remove newline and add after license * test: test and docs for replace_in_file and canonicalized_path function * docs: fix links and comments * fix: link * refactor: remove unused dependencies * refactor: remove unused errors in pop_parachain * refactor: include replace_in_file in common crate * feat(new): improve new contract with a ContractType for categorization (#220) * feat(new): update templates in new contract with ContractType * fix(new): shorter name and test fix * refactor: rename flag to contract_type * docs: apply feedback --------- Co-authored-by: Peter White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.