draft: build parachain on missing local binaries #207
Conversation
bolajahmad
force-pushed
the
build-parachain-before-up
branch
from
0e5f0a8 to
9687770
Compare
There was a problem hiding this comment.
When I try to run it without building it i am getting an error:
┌ Pop CLI : Building your parachain
│
Error: No such file or directory (os error 2)
I think is because of the path you are sending to the build_parachain function is incorrect.
The steps to replicate the error are:
pop new parachain my-parachain
cd my-parachain
pop up parachain -f network.toml
Also the CI is failing here: https://github.com/r0gue-io/pop-cli/actions/runs/9517887250/job/26237462632?pr=207 , run cargo fmt --all to fix it
| let local: Vec<_> = missing.iter().filter(|(_, _, local)| *local).collect(); | ||
| if local.len() > 0 { | ||
|
|
||
| for (name, binary, _) in local.iter() { |
There was a problem hiding this comment.
There is a warning binary is not used.
| .black() | ||
| .on_magenta() | ||
| ))?; | ||
| let _ = build_parachain(&Some(PathBuf::from(name.clone())))?; |
There was a problem hiding this comment.
No need for .clone() here
| .black() | ||
| .on_magenta() | ||
| ))?; | ||
| let _ = build_parachain(&Some(PathBuf::from(name.clone())))?; |
There was a problem hiding this comment.
No need for let _ if you use ? after build_parachain
| if local.len() > 0 { | ||
|
|
||
| for (name, binary, _) in local.iter() { | ||
| intro(format!("{}: Building your parachain", style(" Pop CLI ") |
There was a problem hiding this comment.
To keep consistency with the funcionality we have in Contracts, can you add a warning message too? like the one you added for contracts?
log::warning(format!("NOTE: contract has not yet been built."))?;
While trying to spin up a substrate node using
pop up parachain, the command will fail if the node has not been built/compiled already usingpop build parachain.This PR will automatically check if there is a build/binary existing for the node and then allow
pop up...to progress.