Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paseo support #182

Merged
merged 7 commits into from
Jun 25, 2024
Merged

feat: add paseo support #182

merged 7 commits into from
Jun 25, 2024

Conversation

evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented May 17, 2024

Adds chain-spec-generator support, so that pop up can be used to launch local paseo, kusama and polkadot networks.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 85.63380% with 102 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (baacdd3) to head (b6fc316).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   65.16%   67.94%   +2.78%     
==========================================
  Files          37       39       +2     
  Lines        5069     5665     +596     
  Branches     5069     5665     +596     
==========================================
+ Hits         3303     3849     +546     
+ Misses       1248     1231      -17     
- Partials      518      585      +67     
Files Coverage Δ
crates/pop-parachains/src/up/sourcing.rs 86.58% <89.47%> (+0.07%) ⬆️
crates/pop-cli/src/commands/up/parachain.rs 7.77% <0.00%> (-1.08%) ⬇️
crates/pop-parachains/src/up/relay.rs 85.36% <80.95%> (-0.51%) ⬇️
crates/pop-parachains/src/up/parachains.rs 86.38% <83.75%> (+0.89%) ⬆️
crates/pop-parachains/src/up/chain_specs.rs 83.33% <83.33%> (ø)
crates/pop-parachains/src/up/mod.rs 87.95% <87.90%> (+0.82%) ⬆️

... and 11 files with indirect coverage changes

@evilrobot-01 evilrobot-01 marked this pull request as ready for review June 25, 2024 08:07
@evilrobot-01 evilrobot-01 requested a review from AlexD10S June 25, 2024 08:28
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Support for other chains, such as asset-hub and bridge-hub... can be easily added if needed.

@AlexD10S AlexD10S merged commit a14186d into main Jun 25, 2024
15 checks passed
@AlexD10S AlexD10S deleted the frank/feat-paseo branch June 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants