-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to run a script once network is initialized #180
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 49.69% 50.61% +0.91%
==========================================
Files 32 32
Lines 2785 2857 +72
Branches 2785 2857 +72
==========================================
+ Hits 1384 1446 +62
- Misses 1182 1186 +4
- Partials 219 225 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments:
- We need to explain this option in the
README
and if is with an useful example on how can be useful for devs much better. - If I run the example
--cmd "echo Hello from Pop CLI"
as you suggest for a quick test it looks a bit weird, it gets stuck for a few seconds in Running command:echo Hello from Pop CLI
... without really executing it and after it clear the screen to display the information of thepop up
. UX has to be improved, maybe showing the message that is running the command after spawn the networks? - I left a comment about parsing the arguments of the script: pop up -cmd "echo" --args ...
This would be good to test with a simple Subxt script that connects to the launched network. |
Thanks, LGTM now! |
Simple test: