feat: check if build exists before deploying contract with pop up

[bolajahmad]

Closes #34

pop up contract tries to deploy contract even if there is not build found and will eventually throw error because of that. It is necessary to add a check for existing build (and generate one), before continuing with the deployment.

[AlexD10S]

If I don't have the contract build and run bpop up contract works perfectly.
However if I manually build the contract and then run pop up contract is still building it, for some reason it doesn't find the repo !build_path.exists().

[AlexD10S]

If I don't have the contract build and run bpop up contract works perfectly. However if I manually build the contract and then run pop up contract is still building it, for some reason it doesn't find the repo !build_path.exists().

The issue here is with this line:

let build_path = PathBuf::from(
			self.path.clone().unwrap_or("/.".into()).to_string_lossy().to_string()
				+ "/target/release/ink",
		);

release is not needed, check only for target/ink.
Also once this PR is implemented: #102 and the user can specify if build in release mode or debug mode we will have to change it too.

[bolajahmad]

If I don't have the contract build and run bpop up contract works perfectly. However if I manually build the contract and then run pop up contract is still building it, for some reason it doesn't find the repo !build_path.exists().

The issue here is with this line:

let build_path = PathBuf::from(
			self.path.clone().unwrap_or("/.".into()).to_string_lossy().to_string()
				+ "/target/release/ink",
		);

release is not needed, check only for target/ink. Also once this PR is implemented: #102 and the user can specify if build in release mode or debug mode we will have to change it too.

Alright, I'll try to remove the target/ink and see if that helps.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 50.10%. Comparing base (047bee3) to head (5ddd037).

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   50.28%   50.10%   -0.18%     
==========================================
  Files          32       32              
  Lines        2828     2838      +10     
  Branches     2828     2838      +10     
==========================================
  Hits         1422     1422              
- Misses       1183     1193      +10     
  Partials      223      223              

Files	Coverage Δ
crates/pop-cli/src/commands/up/contract.rs	0.00% <0.00%> (ø)

[AlexD10S]

LGTM!
Thanks again for contributing to pop-cli .