chore: polkadot v1.10.0 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
requested changes
May 16, 2024
|
I want to update the links in the pallet template because they are outdated. Will finish as soon as I know what the best place is. |
Daanvdplas
force-pushed
the
daan/chore-polkadot_v1.10.0
branch
from
e4608bc to
3acdcfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 48.43% 50.28% +1.85%
==========================================
Files 32 32
Lines 2707 2828 +121
Branches 2707 2828 +121
==========================================
+ Hits 1311 1422 +111
+ Misses 1194 1183 -11
- Partials 202 223 +21 |
AlexD10S
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mock.rs file had a change coming from the v1.10 upgrade. The Cargo.toml files had both one as well (codec). Right now I changed everything to workspace dependencies which would be ideal. However, when someone creates a new project the
pallets/folder is not yet added to the workspace in the root Cargo.toml file. Putting it here to get your opinion and see if it can easily be resolved.