Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add dependency and license checks #170

Merged
merged 3 commits into from
May 15, 2024
Merged

ci: add dependency and license checks #170

merged 3 commits into from
May 15, 2024

Conversation

evilrobot-01
Copy link
Contributor

Adds cargo-deny to CI workflow for dependency and license checks.

Note: the list of allowed licenses have not yet been validated in terms of compliance. This should be completed before this PR is accepted.

@evilrobot-01 evilrobot-01 requested a review from AlexD10S May 14, 2024 20:49
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.69%. Comparing base (b0660cc) to head (dccc25c).
Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   49.69%   49.69%           
=======================================
  Files          32       32           
  Lines        2785     2785           
  Branches     2785     2785           
=======================================
  Hits         1384     1384           
  Misses       1182     1182           
  Partials      219      219           

@evilrobot-01 evilrobot-01 mentioned this pull request May 14, 2024
deny.toml Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
@AlexD10S AlexD10S self-requested a review May 15, 2024 09:38
@brunopgalvao
Copy link
Contributor

Maybe:

[advisories]
unmaintained = "warn"

@AlexD10S
Copy link
Collaborator

Maybe:

[advisories]
unmaintained = "warn"

Yes, good point.Adding this with this PR: https://github.com/r0gue-io/pop-cli/pull/174/files

* fix: ignore dependencies with a reason to pass the deny checks

* refactor: remove useless comments

* fix: only show warn for unmantained libs
@AlexD10S AlexD10S self-requested a review May 15, 2024 16:06
@AlexD10S AlexD10S merged commit 48eec26 into main May 15, 2024
14 checks passed
@AlexD10S AlexD10S deleted the frank/ci-cargo-deny branch May 15, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants