Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update para id #152

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: update para id #152

merged 1 commit into from
May 9, 2024

Conversation

evilrobot-01
Copy link
Contributor

Should be outside of the system parachain range.

@evilrobot-01 evilrobot-01 requested a review from AlexD10S May 8, 2024 20:40
@AlexD10S
Copy link
Collaborator

AlexD10S commented May 8, 2024

I see in base-parachain we have the para_id: 1000: https://github.com/r0gue-io/base-parachain/blob/main/node/src/chain_spec.rs#L76
We should change it there too.

@evilrobot-01
Copy link
Contributor Author

I see in base-parachain we have the para_id: 1000: https://github.com/r0gue-io/base-parachain/blob/main/node/src/chain_spec.rs#L76 We should change it there too.

Yeah, that comes from the cumulus template: https://github.com/paritytech/polkadot-sdk/blob/6fdb522ded3813f43a539964af78d5fc6d9f1e97/templates/parachain/node/src/chain_spec.rs#L76.

Zombienet effectively replaces whatever value is set in chain_spec.rs with that specified in network config file. It only starts to matter when doing xcm stuff, just thought it would be worth correcting it in the config file prior to first release. I'll open a PR there to keep it consistent.

@AlexD10S AlexD10S merged commit e9dc240 into main May 9, 2024
5 checks passed
@AlexD10S AlexD10S deleted the frank/fix-para-id branch May 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants