test: ensure errors propagated #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
approved these changes
May 7, 2024
peterwht
pushed a commit
that referenced
this pull request
May 8, 2024
* test: ensure errors propagated (#143) * test: relocate integration tests (#144) * test: relocate integration tests * ci: reduce run time * refactor: remove unused import * refactor: improve feature isolation * refactor: remove unnecessary path prefixes * refactor: invert feature Using `--features=no_telemetry` still resulted in inclusion of pop-telemetry in the dependency tree. Using `telemetry` also makes conditional compilation much simpler.
AlexD10S
added a commit
that referenced
this pull request
May 11, 2024
* feat(telemetry): add telemetry for CLI metrics * feat(telemetry): opt-in handler, better error handling and telemetry usage * feat(telemetry): add reporting for errors * refactor(telemetry): reduce duplicated code, add comments, and general refactoring -- incomplete checkpoint * refactor(telemetry): refactor new parachain, and telemetry handling * fix(telemetry): fix error telemetry reporting * test(telemetry): unit tests for telemetry * fix(telemetry): borrowing issue with multi-threads * refactor(telemetry): handle tel_data better * feat(telemetry): add no_telemetry feature flag to disable telemetry * chore: use edition.workspace in toml files * chore: miscallaneous cleanups, documentation, and refactoring * refactor(telemetry): change opt-in to opt-out * chore: cleanup whitespace and comments * refactor: improve feature (#145) * test: ensure errors propagated (#143) * test: relocate integration tests (#144) * test: relocate integration tests * ci: reduce run time * refactor: remove unused import * refactor: improve feature isolation * refactor: remove unnecessary path prefixes * refactor: invert feature Using `--features=no_telemetry` still resulted in inclusion of pop-telemetry in the dependency tree. Using `telemetry` also makes conditional compilation much simpler. * chore(telemetry): update endpoint and website-id * refactor(telemetry): default values in `Telemetry::new` with helper `init` * chore(telemetry): resolve regressions --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Bruno Galvao <[email protected]> Co-authored-by: AlexD10S <[email protected]>
AlexD10S
added a commit
that referenced
this pull request
May 12, 2024
* feat(telemetry): add telemetry for CLI metrics * feat(telemetry): opt-in handler, better error handling and telemetry usage * feat(telemetry): add reporting for errors * refactor(telemetry): reduce duplicated code, add comments, and general refactoring -- incomplete checkpoint * refactor(telemetry): refactor new parachain, and telemetry handling * fix(telemetry): fix error telemetry reporting * test(telemetry): unit tests for telemetry * fix(telemetry): borrowing issue with multi-threads * refactor(telemetry): handle tel_data better * feat(telemetry): add no_telemetry feature flag to disable telemetry * chore: use edition.workspace in toml files * chore: miscallaneous cleanups, documentation, and refactoring * refactor(telemetry): change opt-in to opt-out * chore: cleanup whitespace and comments * refactor: improve feature (#145) * test: ensure errors propagated (#143) * test: relocate integration tests (#144) * test: relocate integration tests * ci: reduce run time * refactor: remove unused import * refactor: improve feature isolation * refactor: remove unnecessary path prefixes * refactor: invert feature Using `--features=no_telemetry` still resulted in inclusion of pop-telemetry in the dependency tree. Using `telemetry` also makes conditional compilation much simpler. * chore(telemetry): update endpoint and website-id * refactor(telemetry): default values in `Telemetry::new` with helper `init` * chore(telemetry): resolve regressions * docs(telemetry): add telemetry docs explaining what we collect and why. * docs(telemetry): add license and small adjustment to readme * docs(telemetry): small adjustments to READMEs --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Bruno Galvao <[email protected]> Co-authored-by: AlexD10S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was not propagating errors encountered whilst running tests, making debugging when running via CI harder. All tests should now fail with the actual error encountered.