Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error parsing polkadot version from github API #142

Merged
merged 3 commits into from
May 9, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented May 7, 2024

Close: #138

In pop up parachain we are getting the last Polkadot release from the GitHub API. If there is something wrong with this call (for example: IP blocked by Github due to rate limit), return at least a default version

@evilrobot-01
Copy link
Contributor

What happens if user already has latest version installed, but is then dropped down to an older default version? It will then attempt to clone and build, potentially failing on the clone for the same reason.

@AlexD10S
Copy link
Collaborator Author

AlexD10S commented May 7, 2024

What happens if user already has latest version installed, but is then dropped down to an older default version? It will then attempt to clone and build, potentially failing on the clone for the same reason.

If user has latest version and the default version is an older one it will download and build the older one. Even if not installing the latest one, at least we are preventing to crash like in: #138
And for an advanced user that knows what version is the last one, can still specify the version with the flag --relay_chain
The clone has not the same limit as the API, so should be fine. Asked in the Github issue #138 (comment).

@AlexD10S AlexD10S merged commit 2b5a86f into main May 9, 2024
1 check passed
@AlexD10S AlexD10S deleted the fix/error-parsing branch May 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running pop up parachain -f ./network.toml: error decoding response body: invalid type: map
3 participants