Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): integrate assets parachain template. #132

Merged
merged 8 commits into from
May 3, 2024

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented May 1, 2024

This PR substitutes #131.

Asset parachain template moved to: https://github.com/r0gue-io/assets-parachain

@al3mart al3mart marked this pull request as ready for review May 2, 2024 02:40
@AlexD10S
Copy link
Collaborator

AlexD10S commented May 2, 2024

Just a small thing. This is the info when running pop new parachain --help:

Options:
  -t, --template <TEMPLATE>            Template to use: 'base' for Pop and 'cpt' and 'fpt' for Parity templates

Can you add there assets? The code is here: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/new/parachain.rs#L25

@evilrobot-01
Copy link
Contributor

Can you add there assets?

We shouldn't have to update this description with each change like this, it is prone to error. It should be general and should either call a function to generate the list of templates based on available enum variants, or refer to another subcommand to show all accepted values.

Seems that clap has something called PossibleValue, so seems that might be the right approach.

@evilrobot-01
Copy link
Contributor

Addressed in #133

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean PR, shows how easy it will be to add templates moving forward.

I would wait until #133 is approved and merged before merging this one.

@evilrobot-01 evilrobot-01 changed the title feat(cli): Integrate assets parachain template. feat(cli): integrate assets parachain template. May 2, 2024
@AlexD10S AlexD10S merged commit 353161d into main May 3, 2024
1 check passed
@AlexD10S AlexD10S deleted the al3mart/feat-assets-template branch May 3, 2024 07:56
peterwht pushed a commit that referenced this pull request May 6, 2024
* feat(cli): nfts template

* style(cli): assets parachain template

* style(cli): contracts parachain description

* fix(cli): ammend template tests

* fix(cli): ammend template tests

* fix(cli): ammend template url

* fix(cli): point to new assets template repo

* style(cli): fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants