-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): integrate assets parachain template. #132
Conversation
Just a small thing. This is the info when running
Can you add there assets? The code is here: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/new/parachain.rs#L25 |
We shouldn't have to update this description with each change like this, it is prone to error. It should be general and should either call a function to generate the list of templates based on available enum variants, or refer to another subcommand to show all accepted values. Seems that clap has something called |
Addressed in #133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean PR, shows how easy it will be to add templates moving forward.
I would wait until #133 is approved and merged before merging this one.
* feat(cli): nfts template * style(cli): assets parachain template * style(cli): contracts parachain description * fix(cli): ammend template tests * fix(cli): ammend template tests * fix(cli): ammend template url * fix(cli): point to new assets template repo * style(cli): fmt
This PR substitutes #131.
Asset parachain template moved to: https://github.com/r0gue-io/assets-parachain