-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(up parachain): improve build ux #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX looks much nicer now.
Can we add a comment explaining why we this callbacks, this code might be confusing:
binary.source(&cache, &|_| {}).await?;
Can we add the same approach in pop build parachain
and pop build contract
?
162b178
to
d39d2c8
Compare
Have improved the types used to better convey usage and intent, along with doc comments for public functions and types.
Can be done fairly easily for others as a separate PR after latest refactor, but would only undertake if the approach is approved. |
* build(deps): update cliclack * feat(up parachain): improve build ux * refactor: address warnings after dependency * refactor: improve callback type * docs: add doc comments * refactor: improve types to better convey intent
Improves the ux when building binaries for
pop up parachain
, by updatingcliclack
and by using a callback to pass underlyingcargo build
status updates back up to cli ui for output.Also adds a retry attempt should the first attempt fail. This is primarily due to an interrupted process, but could potentially be due to a connectivity issue.