Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(up parachain): improve build ux #123

Merged
merged 6 commits into from
May 2, 2024
Merged

Conversation

evilrobot-01
Copy link
Contributor

Improves the ux when building binaries for pop up parachain, by updating cliclack and by using a callback to pass underlying cargo build status updates back up to cli ui for output.

Also adds a retry attempt should the first attempt fail. This is primarily due to an interrupted process, but could potentially be due to a connectivity issue.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX looks much nicer now.
Can we add a comment explaining why we this callbacks, this code might be confusing:
binary.source(&cache, &|_| {}).await?;

Can we add the same approach in pop build parachain and pop build contract ?

@evilrobot-01 evilrobot-01 force-pushed the frank/improve-build-ux branch from 162b178 to d39d2c8 Compare May 1, 2024 00:11
@evilrobot-01
Copy link
Contributor Author

Can we add a comment explaining why we this callbacks, this code might be confusing: binary.source(&cache, &|_| {}).await?;

Have improved the types used to better convey usage and intent, along with doc comments for public functions and types.

Can we add the same approach in pop build parachain and pop build contract ?

Can be done fairly easily for others as a separate PR after latest refactor, but would only undertake if the approach is approved.

@AlexD10S AlexD10S self-requested a review May 1, 2024 08:04
@AlexD10S AlexD10S merged commit 582b8bb into main May 2, 2024
1 check passed
@AlexD10S AlexD10S deleted the frank/improve-build-ux branch May 2, 2024 10:23
@AlexD10S AlexD10S mentioned this pull request May 6, 2024
peterwht pushed a commit that referenced this pull request May 6, 2024
* build(deps): update cliclack

* feat(up parachain): improve build ux

* refactor: address warnings after dependency

* refactor: improve callback type

* docs: add doc comments

* refactor: improve types to better convey intent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants