Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers: is_contract & is_parachain #105

Closed
wants to merge 5 commits into from
Closed

Conversation

weezy20
Copy link
Contributor

@weezy20 weezy20 commented Apr 10, 2024

Close #91
Unblock #92

@AlexD10S
Copy link
Collaborator

I am not sure about adding a method that is not used, it can add dead code.
I prefer to add the code in the PR where the functionality is going to be used, my suggestion is to merge this in #92 instead of main.

@weezy20
Copy link
Contributor Author

weezy20 commented Apr 10, 2024

@AlexD10S Okay will do that.

@weezy20 weezy20 closed this Apr 25, 2024
@weezy20 weezy20 deleted the w/project-detection branch June 27, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop Build - Parachain/Contract cargo project detection on current working dir
2 participants