-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pop new <contract | parachain>
consistent
#100
Conversation
cf66af8
to
6876460
Compare
pop new contract
pop new contract | parachain
c3287b8
to
595a475
Compare
pop new contract | parachain
pop new <contract | parachain>
consistent
595a475
to
e6af62a
Compare
Anything need to be updated in the README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense.
Good job 👏
I don't think so. |
In the {Contracts section](https://github.com/r0gue-io/pop-cli?tab=readme-ov-file#contracts) I would change the instruction so that once |
the One upcoming feature is |
new parachain
does not take any-p, --path
arguments butnew contract
does.We should stick to consistent messaging formats across both.
cd into {project_path} and enjoy hacking
should be the default, and paths should be printed only if the user invoked them with-p, --path
Another inconsistency I noticed was given an arbitrary path,
a/b/c
tonew parachain
it would create folders if not present, the same is not done bycreate_smart_contract
. This is now resolved and the corresponding test case has been removed as it's not needed anymore.