refactor: small changes

crates/pop-cli/src/commands/call/chain.rs

@@ -111,11 +111,11 @@ impl CallChainCommand {
 
 			if let Err(e) = result {
 				display_message(&e.to_string(), false, &mut cli)?;
+				break;
 			}
 
-			if !prompt_to_repeat_call
-				|| !cli
-					.confirm("Do you want to perform another call?")
+			if !prompt_to_repeat_call ||
+				!cli.confirm("Do you want to perform another call?")
 					.initial_value(false)
 					.interact()?
 			{
@@ -256,7 +256,7 @@ impl CallChainCommand {
 		let mut use_wallet = self.use_wallet;
 		let suri = match self.suri.as_ref() {
 			Some(suri) => suri.clone(),
-			None => {
+			None =>
 				if !self.use_wallet {
 					if cli.confirm("Do you want to use your browser wallet to sign the transaction? (Selecting 'No' will prompt you to manually enter the secret key URI for signing, e.g., '//Alice')")
 						.initial_value(true)
@@ -269,8 +269,7 @@ impl CallChainCommand {
 						}
 				} else {
 					DEFAULT_URI.to_string()
-				}
-			},
+				},
 		};
 		// Perform signing steps with wallet integration and return early.
 		if use_wallet {
@@ -283,9 +282,8 @@ impl CallChainCommand {
 			return Ok(());
 		}
 		cli.info(format!("Encoded call data: {}", call_data))?;
-		if !self.skip_confirm
-			&& !cli
-				.confirm("Do you want to submit the extrinsic?")
+		if !self.skip_confirm &&
+			!cli.confirm("Do you want to submit the extrinsic?")
 				.initial_value(true)
 				.interact()?
 		{
@@ -313,24 +311,22 @@ impl CallChainCommand {
 	// execute the call via `sudo`.
 	fn configure_sudo(&mut self, chain: &Chain, cli: &mut impl Cli) -> Result<()> {
 		match find_dispatchable_by_name(&chain.pallets, "Sudo", "sudo") {
-			Ok(_) => {
+			Ok(_) =>
 				if !self.sudo {
 					self.sudo = cli
 						.confirm(
 							"Would you like to dispatch this function call with `Root` origin?",
 						)
 						.initial_value(false)
 						.interact()?;
-				}
-			},
-			Err(_) => {
+				},
+			Err(_) =>
 				if self.sudo {
 					cli.warning(
 						"NOTE: sudo is not supported by the chain. Ignoring `--sudo` flag.",
 					)?;
 					self.sudo = false;
-				}
-			},
+				},
 		}
 		Ok(())
 	}
@@ -346,11 +342,11 @@ impl CallChainCommand {
 
 	// Function to check if all required fields are specified.
 	fn requires_user_input(&self) -> bool {
-		self.pallet.is_none()
-			|| self.function.is_none()
-			|| self.args.is_empty()
-			|| self.url.is_none()
-			|| self.suri.is_none()
+		self.pallet.is_none() ||
+			self.function.is_none() ||
+			self.args.is_empty() ||
+			self.url.is_none() ||
+			self.suri.is_none()
 	}
 
 	/// Replaces file arguments with their contents, leaving other arguments unchanged.
@@ -432,9 +428,8 @@ impl Call {
 		tx: DynamicPayload,
 		cli: &mut impl Cli,
 	) -> Result<()> {
-		if !self.skip_confirm
-			&& !cli
-				.confirm("Do you want to submit the extrinsic?")
+		if !self.skip_confirm &&
+			!cli.confirm("Do you want to submit the extrinsic?")
 				.initial_value(true)
 				.interact()?
 		{

crates/pop-contracts/src/up.rs

@@ -110,7 +110,6 @@ pub async fn set_up_upload(
 
 	let upload_exec: UploadExec<DefaultConfig, DefaultEnvironment, Keypair> =
 		UploadCommandBuilder::new(extrinsic_opts).done().await?;
-
 	Ok(upload_exec)
 }