Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export commited editId for further modifications #233

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Swisyn
Copy link
Contributor

@Swisyn Swisyn commented Oct 29, 2024

Hey there!

This PR makes it easier to access important info from the release process. Right now, when a release is uploaded, we get an edit id as part of the response, but it’s only printed as a log message. With this update, the script will export that info as GHA outputs and environment variables, so we can easily use it in other steps if needed (without re-uploading an APK).

Changes:

  • Exports the following outputs:

    • committedEditId – The unique identifier of the committed edit.

    • committedEditIdExpiryTimeSeconds – Time in seconds until the committed edit expires.

  • Sets these values as environment variables:

    • COMMITTED_EDIT_ID
    • COMMITTED_EDIT_ID_EXPIRY_TIME_SECONDS

Now, these values are available for future steps in the workflow—making things a bit smoother! ✌️

@boswelja
Copy link
Collaborator

boswelja commented Nov 2, 2024

Thanks for opening! The code looks good, but can you please update the README with these new fields?

@Swisyn
Copy link
Contributor Author

Swisyn commented Nov 3, 2024

Thank you for the review @boswelja, @r0adkll! README is now up-to-date.

@boswelja boswelja merged commit 75bf79c into r0adkll:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants