Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CXX11 back #234

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Add CXX11 back #234

merged 1 commit into from
Apr 22, 2023

Conversation

paleolimbot
Copy link
Collaborator

@paleolimbot paleolimbot commented Apr 22, 2023

For #232...I also have a winbuilder check queued because I realized there wasn't CXX_STD = CXX11 in Makevars.ucrt (this matters for OBJECTS, so maybe it matters for CXX_STD too).

@codecov-commenter
Copy link

Codecov Report

Merging #234 (35fa7cb) into main (a47db3e) will not change coverage.
The diff coverage is n/a.

❗ Current head 35fa7cb differs from pull request most recent head 0875a17. Consider uploading reports for the commit 0875a17 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          46       46           
  Lines        3524     3524           
=======================================
  Hits         3314     3314           
  Misses        210      210           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paleolimbot
Copy link
Collaborator Author

@edzer this seems to work (but we do get a NOTE about CXX11): https://win-builder.r-project.org/h4Sa5M1JoSWA/00check.log

@edzer edzer merged commit e71c092 into main Apr 22, 2023
@edzer
Copy link
Member

edzer commented Apr 22, 2023

Great! Given how close we are to our final deadline, I suggest I continue with submitting to CRAN now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants