Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for k in s2_cell_child() #230

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Fix documentation for k in s2_cell_child() #230

merged 3 commits into from
Apr 19, 2023

Conversation

paleolimbot
Copy link
Collaborator

Closes #225.

I opted to change the documentation: everywhere else we pass values directly to S2 (e.g., level) even though those are 0-indexed, too. This also has the benefit of not breaking any existing usage.

@codecov-commenter
Copy link

Codecov Report

Merging #230 (4cf665f) into main (90ae67a) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cf665f differs from pull request most recent head 44923ac. Consider uploading reports for the commit 44923ac to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          46       46           
  Lines        3517     3517           
=======================================
  Hits         3307     3307           
  Misses        210      210           
Impacted Files Coverage Δ
R/s2-bounds.R 100.00% <ø> (ø)
R/s2-cell.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paleolimbot paleolimbot merged commit 528d50e into main Apr 19, 2023
@paleolimbot paleolimbot deleted the fix-index-doc branch April 19, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2_child_cell k is 0-indexed
2 participants