Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the review policy #33

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Revise the review policy #33

wants to merge 11 commits into from

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Nov 17, 2024

Based on discussions like r-multiverse/help#83.

@wlandau
Copy link
Member Author

wlandau commented Nov 17, 2024

Implements r-multiverse/help#103.

If approved, this revision will be effective 2024-12-17.

review.md Outdated Show resolved Hide resolved
review.md Outdated Show resolved Hide resolved
review.md Outdated Show resolved Hide resolved
Copy link
Member

@shikokuchuo shikokuchuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to tighten up the wording a little on the licenses section.

Is the idea that admins are free to add to the organizations list? I can think of a few more.

The following is a list of valid open-source licenses that the bot automatically accepts during reviews.
If the package includes one of the license below, it implies that the authors consent to distribute the package in R-multiverse.

* [Artistic 2.0](https://opensource.org/license/artistic-2-0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Artistic 2.0](https://opensource.org/license/artistic-2-0)
* [Apache 2.0](https://opensource.org/license/apache-2-0)
* [Artistic 2.0](https://opensource.org/license/artistic-2-0)

## Recommended licenses

The [Acceptable Use Policy](aup.md) prohibits packages that "violate any applicable laws, regulations, or third-party rights, including intellectual property rights".
In practice, this means each package must have a valid open-source license.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In practice, this means each package must have a valid open-source license.
If a package has a valid open-source license, this ensures that distribution by R-multiverse does not violate the intellectual property rights of the package authors.

The [Acceptable Use Policy](aup.md) prohibits packages that "violate any applicable laws, regulations, or third-party rights, including intellectual property rights".
In practice, this means each package must have a valid open-source license.
The following is a list of valid open-source licenses that the bot automatically accepts during reviews.
If the package includes one of the license below, it implies that the authors consent to distribute the package in R-multiverse.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the package includes one of the license below, it implies that the authors consent to distribute the package in R-multiverse.

Comment on lines +54 to +56
## Modification

No R-multiverse staff member (administrator, moderator, or otherwise) may modify a package in R-multiverse without the explicit consent of the owners declared in the license of the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove this section altogether. It is so outside the expected behaviour of a repository that I don't think we need to cover this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants