Skip to content

Commit

Permalink
Amend defaults for propose_snapshot() (#36)
Browse files Browse the repository at this point in the history
* amend defaults for propose_snapshot()

* advance version
  • Loading branch information
shikokuchuo authored Sep 13, 2024
1 parent f7b8ac4 commit bca7072
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: multiverse.internals
Title: Internal Infrastructure for R-multiverse
Description: R-multiverse requires this internal infrastructure package to
automate contribution reviews and populate universes.
Version: 0.2.11
Version: 0.2.12
License: MIT + file LICENSE
URL: https://github.com/r-multiverse/multiverse.internals
BugReports: https://github.com/r-multiverse/multiverse.internals/issues
Expand Down Expand Up @@ -40,6 +40,6 @@ Suggests:
testthat (>= 3.0.0)
Encoding: UTF-8
Language: en-US
Config/testthat/edition: 3
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
Config/testthat/edition: 3
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# multiverse.internals 0.2.12

* Amend argument defaults in `propose_snapshot()` to include source files.

# multiverse.internals 0.2.11

* Implement `propose_snapshot()`.
Expand Down
2 changes: 1 addition & 1 deletion R/propose_snapshot.R
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
propose_snapshot <- function(
path_staging,
repo_staging = "https://staging.r-multiverse.org",
types = c("win", "mac"),
types = c("src", "win", "mac"),
r_versions = NULL,
mock = NULL
) {
Expand Down
2 changes: 1 addition & 1 deletion man/propose_snapshot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/testthat/test-propose_snapshot.R
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ test_that("propose_snapshot()", {
readLines(file.path(path_staging, "snapshot.url")),
paste0(
"https://staging.r-multiverse.org/api/snapshot/zip",
"?types=win,mac&packages=good1,good2"
"?types=src,win,mac&packages=good1,good2"
)
)
propose_snapshot(
Expand All @@ -59,7 +59,7 @@ test_that("propose_snapshot()", {
readLines(file.path(path_staging, "snapshot.url")),
paste0(
"https://staging.r-multiverse.org/api/snapshot/zip",
"?types=win,mac&binaries=4.5,4.4&packages=good1,good2"
"?types=src,win,mac&binaries=4.5,4.4&packages=good1,good2"
)
)
})

0 comments on commit bca7072

Please sign in to comment.