[WIP] Use raw strings (from R 4.0) #1220
Conversation
| @@ -29,7 +25,7 @@ remove_roxygen_mask <- function(text) { | |||
| #' #' @examples c(1, 2) | |||
| #' @keywords internal | |||
| remove_roxygen_header <- function(text) { | |||
| gsub("^[\\s\t]*@examples(If)?(\\s|\t)*", "", text, perl = TRUE) | |||
| gsub(R"(^[\s\t]*@examples(If)?(\s|\t)*)", "", text, perl = TRUE) | |||
There was a problem hiding this comment.
Was this a bug? That is, should this actually have been \\s|\\t?
There was a problem hiding this comment.
\s stands for space, no? Or should be \\s to escape? It should capture spaces and tabs.
There was a problem hiding this comment.
@IndrajeetPatil are you confident in these topics?
There was a problem hiding this comment.
Not really, but, if that's a question we need to ask, I think our testing suite needs an upgrade 😉
At any rate, I am going to convert this PR to a draft since I'd much rather work on updates needed to make the next CRAN release happen ASAP.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3005c40 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
No description provided.