Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1670 and #1671. Disabled resolve_link_package test #1672

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

robchallen
Copy link

@robchallen robchallen commented Oct 18, 2024

This PR adds in additional functionality: @inheritAllDotParams, which inherits transitively the documentation of ... parameters propagating upwards through the function definitions. This is useful if you extend functions that have already have documentation for ... parameters. Its got potential to cause issues hence new tag. This fixes #1671 and #1670. I could not make all tests pass due to issues with cached test results. (Current error is due to reordering in test output compared to snapshot)

@robchallen robchallen closed this Oct 18, 2024
@robchallen
Copy link
Author

Will re-open with fixes

@robchallen
Copy link
Author

Reopen to test if working now

@robchallen robchallen reopened this Oct 18, 2024
@robchallen robchallen closed this Oct 18, 2024
@robchallen
Copy link
Author

Sigh.

@robchallen robchallen reopened this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@InheritDotParams generates CRAN NOTE when nothing to inherit
1 participant