Register missing S3 methods

r-lib · Mar 17, 2024 · 8d6f5ad · 8d6f5ad
1 parent aef840b
commit 8d6f5ad
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -40,6 +40,7 @@ S3method(remote_package_name,bioc_git2r_remote)
 S3method(remote_package_name,bioc_xgit_remote)
 S3method(remote_package_name,bitbucket_remote)
 S3method(remote_package_name,cran_remote)
+S3method(remote_package_name,default)
 S3method(remote_package_name,git2r_remote)
 S3method(remote_package_name,github_remote)
 S3method(remote_package_name,gitlab_remote)
@@ -48,8 +49,10 @@ S3method(remote_package_name,svn_remote)
 S3method(remote_package_name,url_remote)
 S3method(remote_package_name,xgit_remote)
 S3method(remote_sha,bioc_git2r_remote)
+S3method(remote_sha,bioc_xgit_remote)
 S3method(remote_sha,bitbucket_remote)
 S3method(remote_sha,cran_remote)
+S3method(remote_sha,default)
 S3method(remote_sha,git2r_remote)
 S3method(remote_sha,github_remote)
 S3method(remote_sha,gitlab_remote)

diff --git a/R/install-bioc.R b/R/install-bioc.R
@@ -236,6 +236,7 @@ remote_sha.bioc_git2r_remote <- function(remote, ...) {
   }, error = function(e) NA_character_)
 }
 
+#' @export
 remote_sha.bioc_xgit_remote <- function(remote, ...) {
   url <- paste0(remote$mirror, "/", remote$repo)
   ref <- remote$branch

diff --git a/R/install-remote.R b/R/install-remote.R
@@ -182,7 +182,10 @@ remote_package_name <- function(remote, ...) UseMethod("remote_package_name")
 #' @export
 remote_sha <- function(remote, ...) UseMethod("remote_sha")
 
+#' @export
 remote_package_name.default <- function(remote, ...) remote$repo
+
+#' @export
 remote_sha.default <- function(remote, ...) NA_character_
 
 different_sha <- function(remote_sha, local_sha) {

diff --git a/inst/install-github.R b/inst/install-github.R
diff --git a/install-github.R b/install-github.R