Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sudo to outside execute of system_requirements_internal #279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

move sudo to outside execute of system_requirements_internal #279

wants to merge 3 commits into from

Conversation

lz100
Copy link

@lz100 lz100 commented Mar 2, 2021

If we just want to print out the command with sudo but does not want to execute the command,
current 'pak' does not prepend "sudo" unless you combine execute = TRUE, e.g

pak::pkg_system_requirements("openssl", sudo = TRUE, execute = FALSE)
##  [1] "apt-get install -y libssl-dev"

This pull request moves sudo outside execute, so when sudo = TRUE, execute = FALSE, the sudo will still be prepend to
output.

R/system-requirements.R Outdated Show resolved Hide resolved
Co-authored-by: Jim Hester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants