Support clickable hyperlinks #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Aug 7, 2024
olivroy
commented
Aug 7, 2024
olivroy
commented
Aug 7, 2024
|
Just reinstalled lintr from the PR and confirm that a file with |
|
LGTM now, please add yourself to a NEWS bullet to take credit. Thanks! |
AshesITR
reviewed
Aug 9, 2024
Co-authored-by: AshesITR <[email protected]>
AshesITR
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2645
Basically, this checks for clickable hyperlinks. I also saw that some code was still hidden behind
requireNamespace("cli")but that is no longer required since cli is imported.To my great surprise, this works out of the box in Positron ! for
lintr::lint_package()Before, there were no hyperlinks (lintr 3.1.2)
Lmk if you'd like me to add NEWS for this!