Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw strings in some places #2604

Merged
merged 9 commits into from
Jun 15, 2024
Merged

Use raw strings in some places #2604

merged 9 commits into from
Jun 15, 2024

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Jun 12, 2024

Follow-up to #2603.

Just to give an example of what's available to us with an R 4.0 dependency. I'm sure there's more. I'm also fairly confident tests will fail here 😅

@IndrajeetPatil
Copy link
Collaborator

I'm also fairly confident tests will fail here 😅

You underestimate yourself, sir 😃

The tests look much cleaner now!

Base automatically changed from r-40 to main June 12, 2024 21:19
@AshesITR
Copy link
Collaborator

Checks need to be triggered here somehow.
The change LGTM.

NEWS.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.96%. Comparing base (fc2268f) to head (dbd82a9).
Report is 14 commits behind head on main.

Files Patch % Lines
R/zzz.R 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
- Coverage   98.15%   97.96%   -0.19%     
==========================================
  Files         125      126       +1     
  Lines        5738     5748      +10     
==========================================
- Hits         5632     5631       -1     
- Misses        106      117      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit b96c847 into main Jun 15, 2024
20 checks passed
@AshesITR AshesITR deleted the raw-strings branch June 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants