Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required R version #2603

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Bump required R version #2603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d34b3
Bump required R version
MichaelChirico Jun 12, 2024
db59b87
typo
MichaelChirico Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ License: MIT + file LICENSE
URL: https://lintr.r-lib.org, https://github.com/r-lib/lintr
BugReports: https://github.com/r-lib/lintr/issues
Depends:
R (>= 3.6)
R (>= 4.0)
Imports:
backports (>= 1.1.7),
cli (>= 3.4.0),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
## Notes

* All user-facing messages are now prepared using the `{cli}` package (#2418, @IndrajeetPatil). All messages have been reviewed and updated to be more informative and consistent.
* {lintr} now depens on R version 4.0.0. It already does so implicitly due to recursive upstream dependencies requiring this version; we've simply made that dependency explicit and up-front (#2569, @MichaelChirico).
MichaelChirico marked this conversation as resolved.
Show resolved Hide resolved

# lintr 3.1.2

Expand Down
3 changes: 0 additions & 3 deletions tests/testthat/test-lint_package.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,6 @@ test_that("package using .lintr.R config lints correctly", {
})

test_that("lintr need not be attached for .lintr.R configs to use lintr functions", {
# For some obscure reason, running in the subprocess on this specific version of R
# on Windows stopped working after PR #2446 with 'Package lintr not found'.
if (getRversion() == "3.6.3") skip_on_os("windows")
exprs <- paste(
'options(lintr.linter_file = "lintr_test_config")',
sprintf('lints <- lintr::lint_package("%s")', test_path("dummy_packages", "RConfig")),
Expand Down
Loading