Skip to content

Make require_testthat helper function #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 13, 2025

Conversation

F-Noelle
Copy link
Contributor

@F-Noelle F-Noelle commented May 28, 2024

Addresses issues (#2585)

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why there were no lint failures for using = to assign variables...

@MichaelChirico
Copy link
Collaborator

I wonder why there were no lint failures for using = to assign variables...

just that CI hadn't finished yet hehe

MichaelChirico
MichaelChirico previously approved these changes Feb 13, 2025
@MichaelChirico
Copy link
Collaborator

Thank you! Sorry for the delay, I was saving this for after release and then, well, release took some time :)

@MichaelChirico
Copy link
Collaborator

Uh, #2252 binding here.

@MichaelChirico MichaelChirico merged commit 5982a8b into r-lib:main Feb 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect_lint() error for missing {testthat} should reference which function called it
3 participants