Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check vigilant workflow when tests run in parallel #2238

Closed
wants to merge 1 commit into from

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Oct 13, 2023

@MichaelChirico, @AshesITR Do you know why test_dir() fails to run tests when the tests are run in parallel with "warnings-as-errors" setting turned on?

I am not arguing for turning parallel testing on for our test suite. It's just something I noticed while playing around and was curious to understand further.

@AshesITR
Copy link
Collaborator

I have no idea. Seems to fail pretty early.
Maybe worth asking over at the testthat repo?

@IndrajeetPatil
Copy link
Collaborator Author

Maybe worth asking over at the testthat repo?

I would do that if this is indeed a bug or something. But I am not sure if they tolerate me using the issue to ask for clarification, so prefer not to do that as yet.

@AshesITR
Copy link
Collaborator

Sure, but maybe trying to create a reprex helps find the issue anyway?

@IndrajeetPatil
Copy link
Collaborator Author

Closing in favour of #2297

@IndrajeetPatil IndrajeetPatil deleted the test-warnings-in-parallel-mode branch November 17, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants