Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check with the oldest supported R version #1551

Merged
merged 5 commits into from
Sep 25, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Sep 23, 2022

The oldest R version we can check is R 3.4 (r-lib/pak#417 (comment)).

Given that we can't check on older R versions (or is there a way?) and thus can't confirm support for that R version either way, should we be bumping the minimum needed R version to 3.4? (Currently, we support R >= 3.2.)

@IndrajeetPatil

This comment was marked as outdated.

@IndrajeetPatil IndrajeetPatil changed the title WIP: Check with the oldest supported R version Check with the oldest supported R version Sep 24, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review September 24, 2022 16:35
@IndrajeetPatil
Copy link
Collaborator Author

Given that we can't check on older R versions (or is there a way?) and thus can't confirm support for that R version either way, should we be bumping the minimum needed R version to 3.4? (Currently, we support R >= 3.2.)

@MichaelChirico Any thoughts on this?

@MichaelChirico
Copy link
Collaborator

Is pak a requirement for GHA or one of our upstream dependencies?

@IndrajeetPatil
Copy link
Collaborator Author

It's a requirement for GHA, but, IINM, that's the only way we have to know if things are working as expected on the older versions. Since CRAN doesn't test past oldrel-1. So I am not sure how we can confirm that we indeed support R 3.2, in the sense that most features work as expected for this version.

@MichaelChirico
Copy link
Collaborator

It's not too difficult to install 3.2 locally and test :)

I am basically fine keeping the old version until it's proven not to work.

OTOH, for lintr, its main use case is package development, and people submitting to CRAN are technically supposed to be testing their packages with r-devel. So it seems more reasonable to force newer versions of R, and an alignment to GHA makes sense if folks are relying on GHA to test versions of R unavailable to them locally during development.

So, I'm fine either way. @AshesITR any thoughts?

@IndrajeetPatil
Copy link
Collaborator Author

I am basically fine keeping the old version until it's proven not to work.

Okay, I am fine with that.

I was just curious to hear your thoughts on this, apropos testing older R versions on GHA.

@IndrajeetPatil IndrajeetPatil merged commit cf44580 into main Sep 25, 2022
@IndrajeetPatil IndrajeetPatil deleted the check_with_old_r branch September 25, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants