Remove a few linters from efficiency tag (#2655)

* Remove a few linters from efficiency tag closes #2653 * Update NEWS.md * Update NEWS.md Co-authored-by: Michael Chirico <[email protected]> --------- Co-authored-by: Michael Chirico <[email protected]>
r-lib · Sep 5, 2024 · 7fa4876 · 7fa4876
1 parent 64c8baa
commit 7fa4876
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 13 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -18,6 +18,8 @@
 * `cyclocomp_linter()` is no longer part of the default linters (#2555, @IndrajeetPatil) because the tidyverse style guide doesn't contain any guidelines on meeting certain complexity requirements. Note that users with `cyclocomp_linter()` in their configs may now need to install {cyclocomp} intentionally, in particular in CI/CD pipelines.
 * `scalar_in_linter` is now configurable to allow other `%in%` like operators to be linted. The data.table operator `%chin%` is no longer linted by default; use `in_operators = "%chin%"` to continue linting it. (@F-Noelle)
 * `lint()` and friends now normalize paths to forward slashes on Windows (@olivroy, #2613).
+* `undesirable_function_linter()`, `undesirable_operator_linter()`, and `list_comparison_linter()` were removed from the tag `efficiency` (@IndrajeetPatil, #2655). If you use `linters_with_tags("efficiency")` to include these linters, you'll need to adjust your config to keep linting your code against them. We did not find any such users on GitHub.
+
 
 ## Bug fixes
 

diff --git a/inst/lintr/linters.csv b/inst/lintr/linters.csv
@@ -52,7 +52,7 @@ length_test_linter,common_mistakes efficiency
 lengths_linter,efficiency readability best_practices
 library_call_linter,style best_practices readability configurable
 line_length_linter,style readability default configurable
-list_comparison_linter,best_practices common_mistakes efficiency
+list_comparison_linter,best_practices common_mistakes
 literal_coercion_linter,best_practices consistency efficiency
 matrix_apply_linter,readability efficiency
 missing_argument_linter,correctness common_mistakes configurable
@@ -108,8 +108,8 @@ terminal_close_linter,best_practices robustness
 todo_comment_linter,style configurable
 trailing_blank_lines_linter,style default
 trailing_whitespace_linter,style default configurable
-undesirable_function_linter,style efficiency configurable robustness best_practices
-undesirable_operator_linter,style efficiency configurable robustness best_practices
+undesirable_function_linter,style configurable robustness best_practices
+undesirable_operator_linter,style configurable robustness best_practices
 unnecessary_concatenation_linter,style readability efficiency configurable
 unnecessary_lambda_linter,best_practices efficiency readability configurable
 unnecessary_nested_if_linter,readability best_practices deprecated

diff --git a/man/efficiency_linters.Rd b/man/efficiency_linters.Rd
diff --git a/man/linters.Rd b/man/linters.Rd
diff --git a/man/list_comparison_linter.Rd b/man/list_comparison_linter.Rd
diff --git a/man/undesirable_function_linter.Rd b/man/undesirable_function_linter.Rd
diff --git a/man/undesirable_operator_linter.Rd b/man/undesirable_operator_linter.Rd