Delete tests/testthat/test-cpp.R #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would not be in favor of deleting. This file documents that there are low level tests that can (and ideally should) be run. Once you delete the file, nobody will remember this, and if somebody finds the test code they won't know what to do with it. |
|
I think it's just as easy to forget a file exists somewhere in the source tree -- I would recommend filing an issue to track this instead. (of course I am not maintaining the code, so it's up to you 😃) |
|
I'm no longer the maintainer either. But an issue seems a reasonable suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't do anything, and seems easy to restore later.