Skip to content

Commit

Permalink
ci: Import from actions-sync, check carefully (#504)
Browse files Browse the repository at this point in the history
* ci: Import from actions-sync, check carefully

* chore: Auto-update from GitHub Actions

Run: https://github.com/r-dbi/DBI/actions/runs/12195187002
  • Loading branch information
krlmlr authored Dec 6, 2024
1 parent 234e452 commit 8f205f9
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 14 deletions.
1 change: 0 additions & 1 deletion .github/dep-suggests-matrix.json

This file was deleted.

1 change: 0 additions & 1 deletion .github/versions-matrix.json

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
lock:
runs-on: ubuntu-24.04
steps:
- uses: dessant/lock-threads@v5
- uses: krlmlr/lock-threads@patch-1
with:
github-token: ${{ github.token }}
issue-inactive-days: "365"
Expand Down
16 changes: 8 additions & 8 deletions R/00-Id.R
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ dbQuoteIdentifier_DBIConnection_Id <- function(conn, x, ...) {


orderIdParams <- function(
...,
database = NULL,
db = NULL,
catalog = NULL,
cluster = NULL,
schema = NULL,
table = NULL,
column = NULL) {
...,
database = NULL,
db = NULL,
catalog = NULL,
cluster = NULL,
schema = NULL,
table = NULL,
column = NULL) {
out <- c(
database = database,
db = db,
Expand Down
4 changes: 1 addition & 3 deletions vignettes/backend.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,7 @@ Next, implement `dbHasCompleted()` which should return a `logical` indicating if

```{r}
#' @export
setMethod("dbHasCompleted", "KazamResult", function(res, ...) {
})
setMethod("dbHasCompleted", "KazamResult", function(res, ...) {})
```

With these four methods in place, you can now use the default `dbGetQuery()` to send a query to the database, retrieve results if available and then clean up. Spend some time now making sure this works with an existing database, or relax and let the `DBItest` package do the work for you.
Expand Down

0 comments on commit 8f205f9

Please sign in to comment.