chapter 3 review

[tgerke]

Light copy edits.

• Several changes from case_when to if_else for consistency, when appropriate.
• Some changes from ifelse to if_else which is better practice for type consistency and handling NA when they occur

In our next meeting, can we discuss the format of the exchangeability figures? I think they're helpful, but I have to study them for a very long time to understand what they're telling me; axis labelling may be a culprit. Is there another resource/paper that displays exchangeability like this which we could point to?

[malcolmbarrett]

Yes, I think discussing improvements to those figures is a good idea.

Going forward, when you have a suggestion like "we use ifelse but I think we should use if_else", could you discuss it in #309 instead of including it in a PR? These are bigger consistency issues worth discussing before making changes in a single slice of the book. In this case, you're committing to quite a change because I never use if_else(). But also I don't use it for a reason.

[malcolmbarrett]

reverted ifelse() for now until we decided in #310