Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First g computation sections #225

Merged
merged 16 commits into from
Mar 8, 2024
Merged

First g computation sections #225

merged 16 commits into from
Mar 8, 2024

Conversation

tgerke
Copy link
Collaborator

@tgerke tgerke commented Dec 20, 2023

The broader chapter still in progress, but would be good to get some feedback on this presentation ordering (i.e. a preference to show Monte Carlo first, with the "data stacking" technique introduced later as a special case)

@tgerke tgerke marked this pull request as draft December 20, 2023 21:25
@malcolmbarrett
Copy link
Collaborator

Ok, I think I'm on board with this because I think I see the pedagogical advantage. Maybe the data stacking can even just be a longer callout box, e.g. for these simple cases you can use this one weird trick

I think we should address the question of sample size, like how does the sample from the model relate to the number for the monte carlo and the ultimate variance, e.g. the one from the bootstrap or whatever? I think this might relate to how g-comp can technically be more efficient while still being accurate but I don't remember the nitty gritty of our conversation about this

@tgerke
Copy link
Collaborator Author

tgerke commented Dec 27, 2023

Cool, good call re: sample size. I was planning to be more intentional about this is the subsequent section that uses bootstrap for CIs etc. Will remember to circle back to the initial section to pick a resample size that's more deliberate. I have a ref for this somewhere, stay tuned :)

Copy link
Collaborator

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig into the writing as much but overall very happy with the code pattern, so I think you can continue on!

chapters/15-g-comp.qmd Outdated Show resolved Hide resolved
chapters/15-g-comp.qmd Show resolved Hide resolved
chapters/15-g-comp.qmd Outdated Show resolved Hide resolved
chapters/15-g-comp.qmd Show resolved Hide resolved
chapters/15-g-comp.qmd Show resolved Hide resolved
chapters/15-g-comp.qmd Show resolved Hide resolved
chapters/15-g-comp.qmd Show resolved Hide resolved
@tgerke tgerke marked this pull request as ready for review March 8, 2024 19:35
@tgerke tgerke merged commit 73b2c29 into r-causal:main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants