Suppress survey warning and restore estimands chapter #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are suppressing a warning we are seeing from survey all of a sudden about certain weights like the ATT where the psuedopopulation is smaller than the actual population. @LucyMcGowan is investigating why exactly we are seeing this, whether changes in survey or gtsummary. Hopefully we can address it directly upstream without needing to suppress them.
Also, it appears an earlier merge conflict mangled the estimands chapter (where these appear) so this PR also restores the chapter to its correct state.