Making pr #235
Making pr #235
Conversation
…ate a pull request when done. Still need to do a lot of work, but we are getting there.
|
This is wonderful progress, great work. Eventually, I think the hope would be for branch selection to be a dropdown, with a |
|
|
||
| pub async fn list_branches_handler( | ||
| State(state): State<AppState>, | ||
| ) -> Result<(StatusCode, Json<serde_json::Value>), (StatusCode, Json<serde_json::Value>)> { |
There was a problem hiding this comment.
Same as the other one, a more strongly typed json plz
There was a problem hiding this comment.
Can you explain more what you mean by a more strongly typed json?
There was a problem hiding this comment.
Just using a struct that implements serialize/de serialize, rather than a serde_json::Value. Again, it's fine if you would prefer to just switch it to a serde_json::Object, but at that point I'd ask that you explain what exactly it returns in the function docstring.
|
Yes please, just a single github route creator
…On Fri, Oct 18, 2024 at 20:08 TheKrol ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On backend/src/handlers_prelude/github_list_branches.rs
<#235 (comment)>:
I'm okay with that, should I put the routes in with them?
—
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASCMLYSGYCWHK3DZTXV3YTLZ4G5KNAVCNFSM6AAAAABP5ZEWBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZZGE4DCMZUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No description provided.