Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch dependencies using Ivy #1216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fetch dependencies using Ivy #1216

wants to merge 3 commits into from

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Nov 11, 2023 •
edited
Loading

Removes dependant libraries from the source repository and fetches them from Maven Central using ivy.

@tresf
Copy link
Contributor Author

tresf commented Nov 11, 2023 •
edited
Loading

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

@tresf
Copy link
Contributor Author

tresf commented Mar 13, 2024 •
edited
Loading

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

Gluon has informed us that linux-monocle is being merged to mainline JavaFX as Headless instead. This is great news. We've provided Gluon with initial test results and they look promising. Once mainline has received the new Headless support, we can move to Ivy for good.

@tresf tresf mentioned this pull request Oct 23, 2024
Closed
@tresf tresf mentioned this pull request Dec 7, 2024
Merged
@tresf
Copy link
Contributor Author

tresf commented Dec 7, 2024

Once mainline has received the new Headless support, we can move to Ivy for good.

This has progressed since opening this PR: #1225 (comment). Since "Headless" requires Java 21 or higher, this PR must be merged with #1222 in order to test the headless libraries.

@tresf tresf changed the base branch from master to jdk21 December 7, 2024 19:02
Base automatically changed from jdk21 to master December 10, 2024 21:35
@tresf
Copy link
Contributor Author

tresf commented Dec 11, 2024

This PR is in surprisingly good shape... One outstanding issue is that the JavaFX version that we bundle is currently broken for vector (rasterize: false) prints. We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

tray/ant/ivy-deps.properties

Line 16 in f0cbadf

javafx.version=24-headless+0-2024-12-02-101029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tresf