-
Notifications
You must be signed in to change notification settings - Fork 197
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
1 addition
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c5bb51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-Linter Report⚠️
Some files did not pass the configured checks!
clang-format (v15.0.7) reports: 4 file(s) not formatted
clang-tidy (v15.0.7) reports: 4534 concern(s)
src/server/QXmppIncomingServer.cpp:22:53: warning: [readability-identifier-length]
QXmppIncomingServerPrivate(QXmppIncomingServer *qq); ^
src/server/QXmppIncomingServer.cpp:23:13: warning: [modernize-use-trailing-return-type]
src/server/QXmppIncomingServer.cpp:25:19: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingServer.cpp:26:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingServer.cpp:27:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingServer.cpp:33:1: warning: [cppcoreguidelines-pro-type-member-init]
QXmppIncomingServerPrivate::QXmppIncomingServerPrivate(QXmppIncomingServer *qq) ^
src/server/QXmppIncomingServer.cpp:33:77: warning: [readability-identifier-length]
QXmppIncomingServerPrivate::QXmppIncomingServerPrivate(QXmppIncomingServer *qq) ^
src/server/QXmppIncomingServer.cpp:38:37: warning: [modernize-use-trailing-return-type]
src/server/QXmppIncomingServer.cpp:40:17: warning: [cppcoreguidelines-init-variables]
src/server/QXmppOutgoingServer.cpp:21:7: warning: [cppcoreguidelines-pro-type-member-init]
src/server/QXmppIncomingClient.cpp:26:53: warning: [readability-identifier-length]
QXmppIncomingClientPrivate(QXmppIncomingClient *qq); ^
src/server/QXmppIncomingClient.cpp:27:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:29:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:30:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:31:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:32:27: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:33:22: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppIncomingClient.cpp:36:13: warning: [modernize-use-trailing-return-type]
src/server/QXmppIncomingClient.cpp:42:1: warning: [cppcoreguidelines-pro-type-member-init]
QXmppIncomingClientPrivate::QXmppIncomingClientPrivate(QXmppIncomingClient *qq) ^
src/server/QXmppIncomingClient.cpp:42:77: warning: [readability-identifier-length]
QXmppIncomingClientPrivate::QXmppIncomingClientPrivate(QXmppIncomingClient *qq) ^
src/server/QXmppIncomingClient.cpp:47:34: warning: [readability-convert-member-functions-to-static]
src/server/QXmppIncomingClient.cpp:53:45: warning: [bugprone-branch-clone]
src/server/QXmppIncomingClient.cpp:70:37: warning: [modernize-use-trailing-return-type]
src/server/QXmppIncomingClient.cpp:72:17: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:32:13: warning: [cppcoreguidelines-init-variables]
QString xmlns = element.namespaceURI(); ^ = 0
src/server/QXmppServer.cpp:36:22: warning: [cppcoreguidelines-init-variables]
QDomNamedNodeMap attrs = element.attributes(); ^ = 0
src/server/QXmppServer.cpp:38:18: warning: [cppcoreguidelines-init-variables]
QDomAttr attr = attrs.item(i).toAttr(); ^ = 0
src/server/QXmppServer.cpp:43:14: warning: [cppcoreguidelines-init-variables]
QDomNode childNode = element.firstChild(); ^ = 0
src/server/QXmppServer.cpp:58:37: warning: [readability-identifier-length]
QXmppServerPrivate(QXmppServer *qq); ^
src/server/QXmppServer.cpp:60:10: warning: [modernize-use-trailing-return-type]
src/server/QXmppServer.cpp:60:35: warning: [readability-identifier-length]
src/server/QXmppServer.cpp:67:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:68:35: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:69:18: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:70:27: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:70:27: warning: [modernize-use-default-member-init]
QXmppPasswordChecker *passwordChecker; ^ {nullptr}
src/server/QXmppServer.cpp:73:33: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:74:43: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:76:28: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:79:33: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:80:33: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:81:28: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:84:28: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:85:21: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:86:13: warning: [cppcoreguidelines-non-private-member-variables-in-classes]
src/server/QXmppServer.cpp:89:10: warning: [modernize-use-default-member-init]
src/server/QXmppServer.cpp:90:10: warning: [modernize-use-default-member-init]
src/server/QXmppServer.cpp:94:1: warning: [cppcoreguidelines-pro-type-member-init]
QXmppServerPrivate::QXmppServerPrivate(QXmppServer *qq) ^
src/server/QXmppServer.cpp:94:53: warning: [readability-identifier-length]
QXmppServerPrivate::QXmppServerPrivate(QXmppServer *qq) ^
src/server/QXmppServer.cpp:109:26: warning: [modernize-use-trailing-return-type]
src/server/QXmppServer.cpp:109:36: warning: [bugprone-easily-swappable-parameters]
src/server/QXmppServer.cpp:109:51: warning: [readability-identifier-length]
src/server/QXmppServer.cpp:112:19: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:119:38: warning: [cppcoreguidelines-init-variables]
QList<QXmppIncomingClient *> found; ^ = 0
src/server/QXmppServer.cpp:126:34: warning: [cppcoreguidelines-init-variables]
QXmppIncomingClient *conn = incomingClientsByJid.value(to); ^ = nullptr
src/server/QXmppServer.cpp:127:17: warning: [readability-implicit-bool-conversion]
src/server/QXmppServer.cpp:138:7: warning: [readability-else-after-return]
src/server/QXmppServer.cpp:151:15: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:161:16: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:161:16: warning: [readability-identifier-length]
src/server/QXmppServer.cpp:192:19: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:193:19: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:193:19: warning: [readability-identifier-length]
src/server/QXmppServer.cpp:197:21: warning: [cppcoreguidelines-init-variables]
QXmppIq request; ^ = 0
src/server/QXmppServer.cpp:201:25: warning: [modernize-use-trailing-return-type]
QXmppIq response(QXmppIq::Error); ^
src/server/QXmppServer.cpp:216:21: warning: [cppcoreguidelines-init-variables]
QXmppIq request; ^ = 0
src/server/QXmppServer.cpp:219:21: warning: [modernize-use-trailing-return-type]
QXmppIq response(QXmppIq::Error); ^
src/server/QXmppServer.cpp:231:26: warning: [readability-convert-member-functions-to-static]
src/server/QXmppServer.cpp:238:26: warning: [readability-convert-member-functions-to-static]
src/server/QXmppServer.cpp:288:18: warning: [cppcoreguidelines-init-variables]
src/server/QXmppServer.cpp:888:7: warning: [cppcoreguidelines-pro-type-member-init]
src/omemo/QXmppOmemoManager.cpp:6:10: error: [clang-diagnostic-error]
src/omemo/QXmppOmemoManager.cpp:30:7: warning: [cppcoreguidelines-pro-type-member-init]
src/omemo/QXmppOmemoManager.cpp:106:7: warning: [cppcoreguidelines-pro-type-member-init]
src/omemo/QXmppOmemoData.cpp:415:52: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoData.cpp:425:34: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoData.cpp:440:48: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoData.cpp:450:32: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:66:5: warning: [cppcoreguidelines-pro-type-member-init]
src/omemo/QXmppOmemoManager_p.cpp:66:13: warning: [bugprone-easily-swappable-parameters]
src/omemo/QXmppOmemoManager_p.cpp:75:29: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:90:30: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:103:34: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:116:30: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:130:34: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:148:12: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:161:16: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:166:16: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:172:16: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:199:6: warning: [cppcoreguidelines-avoid-non-const-global-variables]
src/omemo/QXmppOmemoManager_p.cpp:204:1: warning: [cppcoreguidelines-pro-type-member-init]
QXmppOmemoManagerPrivate::QXmppOmemoManagerPrivate(Manager *parent, QXmppOmemoStorage *omemoStorage) ^
src/omemo/QXmppOmemoManager_p.cpp:231:22: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:231:22: warning: [readability-convert-member-functions-to-static]
src/omemo/QXmppOmemoManager_p.cpp:238:16: warning: [readability-simplify-boolean-expr]
src/omemo/QXmppOmemoManager_p.cpp:249:22: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:249:22: warning: [readability-convert-member-functions-to-static]
src/omemo/QXmppOmemoManager_p.cpp:252:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:253:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:258:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:259:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:265:16: warning: [readability-simplify-boolean-expr]
src/omemo/QXmppOmemoManager_p.cpp:276:22: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:276:22: warning: [readability-convert-member-functions-to-static]
src/omemo/QXmppOmemoManager_p.cpp:282:16: warning: [readability-simplify-boolean-expr]
src/omemo/QXmppOmemoManager_p.cpp:314:52: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:316:40: warning: [cppcoreguidelines-init-variables]
signal_protocol_identity_key_store store; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:318:38: warning: [bugprone-easily-swappable-parameters]
src/omemo/QXmppOmemoManager_p.cpp:319:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:320:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:323:15: warning: [bugprone-assignment-in-if-condition]
src/omemo/QXmppOmemoManager_p.cpp:329:15: warning: [bugprone-assignment-in-if-condition]
src/omemo/QXmppOmemoManager_p.cpp:338:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:339:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:370:54: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:372:42: warning: [cppcoreguidelines-init-variables]
signal_protocol_signed_pre_key_store store; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:375:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:376:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:383:15: warning: [bugprone-assignment-in-if-condition]
src/omemo/QXmppOmemoManager_p.cpp:392:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:393:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:395:45: warning: [cppcoreguidelines-init-variables]
QXmppOmemoStorage::SignedPreKeyPair signedPreKeyPair; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:397:44: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:406:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:407:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:412:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:413:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:434:47: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:436:35: warning: [cppcoreguidelines-init-variables]
signal_protocol_pre_key_store store; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:439:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:440:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:447:15: warning: [bugprone-assignment-in-if-condition]
src/omemo/QXmppOmemoManager_p.cpp:456:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:457:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:458:40: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:465:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:466:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:471:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:472:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:496:47: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:498:35: warning: [cppcoreguidelines-init-variables]
signal_protocol_session_store store; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:501:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:502:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:511:15: warning: [bugprone-assignment-in-if-condition]
src/omemo/QXmppOmemoManager_p.cpp:520:25: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:521:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:535:26: warning: [cppcoreguidelines-init-variables]
signal_int_list *deviceIds = signal_int_list_alloc(); ^ = nullptr
src/omemo/QXmppOmemoManager_p.cpp:549:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:550:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:551:41: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:562:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:563:21: warning: [readability-identifier-length]
src/omemo/QXmppOmemoManager_p.cpp:569:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:570:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:582:31: warning: [cppcoreguidelines-pro-type-reinterpret-cast]
src/omemo/QXmppOmemoManager_p.cpp:583:15: warning: [readability-identifier-length]
auto *d = manager->d.get(); ^
src/omemo/QXmppOmemoManager_p.cpp:616:33: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:654:51: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:656:14: warning: [cppcoreguidelines-init-variables]
src/omemo/QXmppOmemoManager_p.cpp:669:51: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:671:14: warning: [cppcoreguidelines-init-variables]
src/omemo/QXmppOmemoManager_p.cpp:690:22: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:690:22: warning: [readability-convert-member-functions-to-static]
src/omemo/QXmppOmemoManager_p.cpp:736:22: warning: [readability-convert-member-functions-to-static]
src/omemo/QXmppOmemoManager_p.cpp:756:50: warning: [cppcoreguidelines-init-variables]
RefCountedPtr<ratchet_identity_key_pair> identityKeyPair; ^ = 0
src/omemo/QXmppOmemoManager_p.cpp:786:22: warning: [modernize-use-trailing-return-type]
src/omemo/QXmppOmemoManager_p.cpp:788:43: warning: [cppcoreguidelines-init-variables]
RefCountedPtr<session_signed_pre_key> signedPreKeyPair; ^ = 0
Have any feedback or feature suggestions? Share it here.