FIX #245: Error while running nx generate qwik-nx:app
#246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Resolved #245, created compatibility with
nx: 20.7.1
.The current issue was happening because of the
ensureProjectName
function, now that nx has updated and this does not work like used to do.I Have done quick fix so the package can be used with the nx 20.7.1, still need some advice on how to make it work when the user do not use the
--name
flag with the command, maybe create a default name likemyApp
andmyLib
?Use cases and why
Actual behavior:
nx 20.7.1
we are unable to generate new apps or libsExpected behavior:
nx generate qwik-nx:app
should work withnx 20.7.1
Screenshots/Demo
N/A
Checklist: