Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix warnings in google code instead of waiting for google #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

logankaser
Copy link
Collaborator

@logankaser logankaser commented May 18, 2019

instead of waiting for google to figure their shit out..
It's been three months and google can't be bothered to fix the used variable warnings they have.
So I did it.
Two (void)var later it compiles with no warnings. Yup all those warnings were from two places.

@logankaser logankaser changed the title Manually fix warnings in google code instead of waiting for google to… Manually fix warnings in google code instead of waiting for google May 18, 2019
@logankaser logankaser requested a review from theo-walton May 18, 2019 13:39
@theo-walton
Copy link
Collaborator

what is that other binary you replaced it with? an older version? Can you not get the older version from brew?

@logankaser
Copy link
Collaborator Author

logankaser commented May 25, 2019

what is that other binary you replaced it with? an older version? Can you not get the older version from brew?

Brew only has native librairies i.e for x86_64, I have to custom compile this for WASM, it's never been from brew (except for the server).

Those two 7z files are the WASM version I compiled.
(Headers are included as well because the header version has to exactly match with the library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants