Allow hook for setting library #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry it's taken me so long to get to this! |
quval
reviewed
May 6, 2021
python_configure.bzl
Outdated
|
|
||
| python_inc_dir = sysconfig.get_python_inc() | ||
| config_h_path = sysconfig.get_config_h_filename() | ||
| shutil.copyfile(config_h_path, python_inc_dir + "/pyconfig.h") |
There was a problem hiding this comment.
Can we somehow avoid this side effect? Wouldn't it fail when using a systemwide installation?
There was a problem hiding this comment.
Hmm. Yeah I don't remember why I made this change- I imagine I did it for some reason. Without the correct permissions this would crash.
We could check to see whether this is needed or possible- but I think it would be better to just remove this.
Not sure. I can test this at some point, but likely not until next week.
There was a problem hiding this comment.
Was it from the patch here? pybind#29 (comment)
I think it might be better to just have the genrule copy it.
There's no hurry anyway :)
* Remove 'local' tag from pybind_extension See pybind#34 for more details. Remote cache in CI works as a charm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up changes too (hopefully not to paternalistic).
Edit: note whitespace changes are from buildifier