Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch progress bar method in EnsembleProblems #259

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

albertomercurio
Copy link
Member

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributor Covenant Code of Conduct
  • Any code changes were done in a way that does not break public API
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR fixes the little performance decrease introduced with PR #254.

Here I use multiple dispatch to either use a RemoteChannel or not to handle the progress bar, depending on the ensemble_method. In this way, we support the best performances of multithreading cases, and also support the progress_bar for Distributed computing in clusters.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 62.19512% with 31 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (2f92e5b) to head (863d7ec).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/time_evolution/ssesolve.jl 58.97% 16 Missing ⚠️
src/time_evolution/mcsolve.jl 63.41% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   94.38%   92.30%   -2.08%     
==========================================
  Files          31       31              
  Lines        2297     2327      +30     
==========================================
- Hits         2168     2148      -20     
- Misses        129      179      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ytdHuang ytdHuang merged commit 87ce64e into qutip:main Oct 8, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants