Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PhysicalConstants and new energy units #257

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Oct 5, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributor Covenant Code of Conduct
  • Any code changes were done in a way that does not break public API
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Summary of this PR:

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (c7a3483) to head (3269f6d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   94.38%   93.51%   -0.88%     
==========================================
  Files          31       31              
  Lines        2297     2297              
==========================================
- Hits         2168     2148      -20     
- Misses        129      149      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio
Copy link
Member

I don't know if we want to use the PhysicalConstants.jl package at this point.

@ytdHuang
Copy link
Member Author

ytdHuang commented Oct 5, 2024

I don't know if we want to use the PhysicalConstants.jl package at this point.

But they didn't update the values for a while.
So I think maybe we just make it by ourselves.

@albertomercurio albertomercurio merged commit 2f92e5b into qutip:main Oct 5, 2024
10 of 11 checks passed
@ytdHuang ytdHuang deleted the add/unit branch October 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants