Fix type instabilities for almost all functions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the previous runtests the benchmark succeded, so I think this was a fluctuation. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 94.89% 93.83% -1.07%
==========================================
Files 29 30 +1
Lines 2115 2124 +9
==========================================
- Hits 2007 1993 -14
- Misses 108 131 +23 ☔ View full report in Codecov by Sentry. |
ytdHuang
reviewed
Sep 9, 2024
ytdHuang
reviewed
Sep 9, 2024
ytdHuang
approved these changes
Sep 9, 2024
albertomercurio
added a commit
to lgravina1997/QuantumToolbox.jl
that referenced
this pull request
Sep 27, 2024
* Improve c_ops handling * Format code * Fix ptrace and operators * Make states stable * Fix type instabilities for qobj methods * FIx eigenvalues * Other fixes and format * Minor changes to dfd_mesolve * Fix typo * Remove version condition of runtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here I solved several type instabilities. I added a test for any of those functions.
In the next PRs I will fix the type instabilities for
dfd_mesolveanddsf_mesolve.Just as an example, the
ptracefunction is now 10 times faster than the one of v0.12.0. I didn't benchmark all the funcitons, but now the code is more clear and efficient.I have also removed the dependency for
LinearMaps.jlsince it was giving a weak type instability. I created an ad-hoc linear map struct for that.