This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Ensure camelcaseKeys is never passed a non-object #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32780 |
|
@nabeel- I'm very new to the project but I think it would be great if you can add a simple test for each of the reducers. |
mmahalwy
reviewed
Nov 27, 2018
| @@ -52,7 +52,9 @@ export default (state = INITIAL_STATE, action: $TsFixMe) => { | |||
| case FETCH_AUDIOPLAYER: { | |||
| return handle(state, action, { | |||
| success: prevState => { | |||
| const audioFile: $TsFixMe = camelcaseKeys(action.payload.audio_file); | |||
| const audioFile: $TsFixMe = camelcaseKeys( | |||
| action.payload.audio_file || {} | |||
There was a problem hiding this comment.
this is awesome! perhaps we should use lodash/get? so get(action, 'payload.audio_file', {}) such that if payload is null, this would still work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure camelcaseKeys is never passed a non-object
Currently, the
/api/v3/juzsendpoint is 500ing, which causescamelcaseKeysto be called withundefined. According to sindresorhus/camelcase-keys#15, we should ensure we never callcamelcaseKeyswith something other than an object. Ideally, this is fixed on the BE where we fix the issue that is causing the BE to 500 but this will at least ensure the FE does not completely break and hang.I suspect this is also the reason why the homepage of the staging site is hanging (http://staging.quran.com/).
Checklist
package-lock.json