Keep cache of messages in database #774
Open
+91
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasFella
force-pushed
the
tobias/message-db
branch
from
c4e351b
to
76fc3d1
Compare
TobiasFella
commented
Jul 17, 2024
TobiasFella
force-pushed
the
tobias/message-db
branch
from
76fc3d1
to
5b328f6
Compare
|
I think this is ready. Please also check whether this is conceptionally sound |
|
This is only solid because the stored messages for each room are guaranteed not to have any missing chunks between them (historical messages always come in starting from the oldest known message and new syncs always bring all new messages). If this ever changes (sliding sync?), this would probably get a whole lot messier |
|
allHistoryLoaded needs to be adapted |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves startup time, general UX, allows for client-side message search in the future, ...
While increasing requiring more storage on the client, of course.
There are some TODOs left in the code for things that need to be implemented and figured out