Merge pull request #6 from quodlibetor/enable-clippy

Enable clippy in CI, fix justified lints

.github/workflows/push.yml

@@ -35,8 +35,9 @@ jobs:
       - name: Set up Rust
         uses: moonrepo/setup-rust@v1
         with:
-          channel: ${{ matrix.rust-version }}
           bins: cargo-nextest
+          channel: ${{ matrix.rust-version }}
+          components: clippy
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -47,3 +48,6 @@ jobs:
         run: cargo nextest run --features diesel-uuid,serde
         env:
           PG_DATABASE_URL: postgres://postgres:postgres@localhost/postgres
+
+      - name: Clippy
+        run: cargo clippy --features diesel-uuid,serde

src/lib.rs

@@ -147,7 +147,9 @@ impl UuidB64 {
         let mut buf = InlineString::from("0000000000000000000000"); // not actually zeroes
         unsafe {
             let raw_buf = buf.as_mut_slice();
-            URL_SAFE_NO_PAD.encode_slice(self.0.as_bytes(), &mut raw_buf[0..22]).unwrap();
+            URL_SAFE_NO_PAD
+                .encode_slice(self.0.as_bytes(), &mut raw_buf[0..22])
+                .unwrap();
         }
         buf
     }
@@ -184,13 +186,21 @@ impl FromStr for UuidB64 {
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         let mut output = [0; 16];
-        URL_SAFE_NO_PAD.decode_slice(s, &mut output)
+        URL_SAFE_NO_PAD
+            .decode_slice(s, &mut output)
             .chain_err(|| ErrorKind::ParseError(s.into()))?;
         let id = Uuid::from_bytes(output);
         Ok(UuidB64(id))
     }
 }
 
+/// Construct a new V4 (random) UUID
+impl Default for UuidB64 {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 /// Right now this is just `Uuid`, but anything Uuid is comfortable with, we are
 impl<T> From<T> for UuidB64
 where

src/serde_impl.rs

@@ -38,7 +38,7 @@ impl<'de> Visitor<'de> for UuidB64Visitor {
     where
         E: de::Error,
     {
-        Ok(s.parse().map_err(de::Error::custom)?)
+        s.parse().map_err(de::Error::custom)
     }
 }