Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamingDataFrame.merge(): prep work #725

Merged
merged 9 commits into from
Jan 24, 2025
Merged

StreamingDataFrame.merge(): prep work #725

merged 9 commits into from
Jan 24, 2025

Conversation

daniil-quix
Copy link
Collaborator

This PR adds some prep work for the merge() feature.
No new features have been added yet, and SDFs are expected to work like before.

I want to merge it before implementing the actual merge() to split the review process into steps.

Main changes:

  • Added support for multiple parents in Stream class to implement the merge() feature.
  • The Stream.compose() method now uses graphlib.TopologicalSorter to resolve the sequence of operations in the tree of Stream objects.
  • With multiple parents, each tree may have multiple root Streams (e.g. when merging 2 SDFs will result in a single tree with two starting points). This PR handles that.

Related to #487

@daniil-quix daniil-quix changed the title StreamingDataFrame.merge(): prep work #722 StreamingDataFrame.merge(): prep work Jan 23, 2025
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
quixstreams/core/stream/stream.py Outdated Show resolved Hide resolved
@daniil-quix daniil-quix merged commit e3795ab into main Jan 24, 2025
3 checks passed
@daniil-quix daniil-quix deleted the feature/merge-prep branch January 24, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants