Include iOS in the conditional compilation for mac platforms #635
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-faber
force-pushed
the
fix-ios
branch
from
2d84bc3 to
d23b6d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! We recently updated the quinn version used in maidsafe/quic-p2p to 0.5.3. But after this update we noticed that our Android & iOS builds were failing. This is because
rustls-native-certsdoesn't support Android and iOS (See rustls/rustls-native-certs#3).Since it's a feature-enabled dependency (enabled by default), I disabled the default features and tried compiling quinn for Android & iOS. The Android build was successful, but the iOS build failed.
The platform-native API for Mac and iOS are the same so adding this condition gave us a passing build and the iOS libraries built were able to successfully establish a connection and exchange messages.